fix: end initialization early if device storage is locked #2520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Add isDeviceStorageUnlocked check to avoid accessing user data before the device is unlocked on Android 7.0+, and end initialization early if device storage is locked.
Details
Motivation
This allows the SDK to avoid reading/writing user data too early (e.g., in boot receivers or early background services), and to avoid crashes with the inconsistent state.
Scope
Terminate the initialization early depends on user storage availability.
Testing
Unit testing
OPTIONAL - Explain unit tests added, if not clear in the code.
Manual testing
Tested on Emulator Pixel 9 API 35
Step to reproduce:
<receiver android:name="com.onesignal.notifications.receivers.BootUpReceiver" android:exported="true" android:directBootAware="true"> <intent-filter> <action android:name="android.intent.action.BOOT_COMPLETED" /> <action android:name="android.intent.action.QUICKBOOT_POWERON" /> <action android:name="android.intent.action.LOCKED_BOOT_COMPLETED"/> </intent-filter> </receiver>adb logcat | grep -E "(SharedPreferences|BootUpReceiver)"
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is